This repository has been archived by the owner on Jan 4, 2019. It is now read-only.
Emit png_data for invalid favicon_url of import from HTML #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkdh
added a commit
to darkdh/browser-laptop
that referenced
this pull request
Sep 28, 2016
fix brave#4339 requires brave/muon#64 Auditors: @bridiver, @bbondy Test Plan: 1. Import bookmarks from HTML file 2. There should be favicon shows when show favicon option is on
4 tasks
bridiver
force-pushed
the
master
branch
2 times, most recently
from
e02fb4f to
730d5fe
Compare
|
++ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditors: @bridiver, @bbondy