Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subtleSubmitReview.js: fix a race condition #217

Merged
merged 1 commit into from
Nov 29, 2024
Merged

subtleSubmitReview.js: fix a race condition #217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/subtleSubmitReview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,10 @@ export default async function subtleSubmitReview ({
name: repo,
prnumber: prnum
}
const msg = (await github.graphql(query, variables)).repository.pullRequest
const msgPre = (await github.graphql(query, variables)).repository.pullRequest

// debounce if the PR description contains a watermark and the debounce time is not expired yet
if (msg.body.includes(watermark) && !isOlderThanXHours(msg.updatedAt, debounceTime)) {
if (msgPre.body.includes(watermark) && !isOlderThanXHours(msgPre.updatedAt, debounceTime)) {
throw new Error('debounce')
}

Expand All @@ -65,6 +65,8 @@ export default async function subtleSubmitReview ({

const newExplaination = '<details><summary>AI Review</summary>' + '\n\n' + watermark + '\n\n' + await explainPatch() + '</details>'

// fetch the message twice, to decrease the chances of race condition, but still debounce
const msg = (await github.graphql(query, variables)).repository.pullRequest
const newBody = msg.body.match(re)
? msg.body.replace(re, newExplaination)
: msg.body + '\n\n' + newExplaination
Expand Down