This repository has been archived by the owner on Jul 31, 2020. It is now read-only.
add isTruncated parameter to GET_EXISTING_OBJECTS #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diracdeltas
added a commit
to brave/browser-laptop
that referenced
this pull request
Apr 18, 2017
brave/sync#73 Test Plan: N/A
4 tasks
ayumi
approved these changes
Apr 18, 2017
client/sync.js
Outdated
| * @param {Array.<Uint8Array>} s3Objects | ||
| * @returns {Array.<Object} | ||
| */ | ||
| const getJSRecords_ = (s3Objects) => { |
There was a problem hiding this comment.
whats the postfix underscore for
There was a problem hiding this comment.
it's a JS convention for a private method/var, same as the prefix usage of underscore
mostly for serg to know when to stop getting the initial sync records also sends GET_EXISTING_OBJECTS and RESOLVED_SYNC_RECORDS regardless of whether records is empty, as joel requested fix #72
diracdeltas
added a commit
to brave/browser-laptop
that referenced
this pull request
Apr 19, 2017
updating sync to match brave/sync#73
bsclifton
pushed a commit
to brave/browser-laptop
that referenced
this pull request
Apr 19, 2017
brave/sync#73 Test Plan: N/A
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly for serg to know when to stop getting the initial sync records
also sends GET_EXISTING_OBJECTS and RESOLVED_SYNC_RECORDS regardless of whether records is empty, as joel requested
fix #72