Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow building using podman #130

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Allow building using podman #130

merged 5 commits into from
Feb 21, 2024

Conversation

waybackarchiver
Copy link
Contributor

No description provided.

Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should instead define $DOCKER in https://github.com/brave/tor_build_scripts/blob/master/env.sh so that it doesn't have to be done in each file? Also, that would allow someone to easily override.

@fmarier
Copy link
Member

fmarier commented Feb 16, 2024

I also note that this defaults to podman when it's installed. I'm not familiar with Podman. Is it superior to Docker? Should Brave be building with Podman?

@waybackarchiver
Copy link
Contributor Author

waybackarchiver commented Feb 16, 2024

It's a rootless implementation of Docker, someone prefers Podman, and there seems to be little difference between the two if we're just using it to build binaries.

I don't know if it would be possible to build Brave using Podman, but that would require a bit more research.

@waybackarchiver
Copy link
Contributor Author

Maybe we should instead define $DOCKER in https://github.com/brave/tor_build_scripts/blob/master/env.sh so that it doesn't have to be done in each file? Also, that would allow someone to easily override.

That's great!

build_linux.sh Outdated Show resolved Hide resolved
env.sh Outdated Show resolved Hide resolved
env.sh Outdated Show resolved Hide resolved
wknapik
wknapik previously approved these changes Feb 21, 2024
@mihaiplesa mihaiplesa merged commit 6235948 into brave:master Feb 21, 2024
1 of 2 checks passed
@waybackarchiver waybackarchiver deleted the podman branch February 22, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants