-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow building using podman #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should instead define $DOCKER
in https://github.com/brave/tor_build_scripts/blob/master/env.sh so that it doesn't have to be done in each file? Also, that would allow someone to easily override.
I also note that this defaults to |
It's a rootless implementation of Docker, someone prefers Podman, and there seems to be little difference between the two if we're just using it to build binaries. I don't know if it would be possible to build Brave using Podman, but that would require a bit more research. |
That's great! |
No description provided.