Address issue #66 #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
your commit to chart.ME.R is all whitespace changes. It is generally considered bad form to mess up the whitespace of existing code when changing only a few lines. It also doesn't make sense to create a second pull request when one already exists in #77. If there are problems with that pull request, they should be addressed there. |
|
I apologize for the whitespace, I noticed it only once made the PR. About the 2nd topic, I thought it would have been somewhat easier for you to review and eventually merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue #66 consistently with xts plotting facility. The default of the new argument
legend.locis 'bottomright' as @braverock suggested. Possibly I would like to hear opinions on setting it toNULLinstead or, better, make graphical modifications so to prevent eventual overlapping with data. In case, I can take care of this.