Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing 404s - June 2024 #7605

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Fixing 404s - June 2024 #7605

merged 2 commits into from
Jul 9, 2024

Conversation

internetisaiah
Copy link
Contributor

@internetisaiah internetisaiah commented Jun 27, 2024

Pull Request/Issue Resolution

Description of Change:

Bi-annual maintenance for fixing 404s - June 2024. Google sheet here.

Here's the links that were fixed (with the latest deployment sub URL):

Is this change associated with a Braze feature/product release?

  • Yes (Insert Feature Release Date Here)
  • No

✔️ Pull Request Checklist
  • Check that you haven't removed any images (replacing an image with an updated one of the same name is fine), as this breaks the French site
  • Check that all links work.
  • Ensure you have completed our Contributors License Agreement.
  • Tag @josh-mccrowell-braze and @internetisaiah as a reviewer when your work is done and ready to be reviewed for merge. Are you an internal product manager? Reference the internal reviewing chart to tag the appropriate reviewer.
  • If the documentation involves a 1) paid SKU, 2) a third party, 3) SMS, 4) AI, or 5) privacy, ensure that Ana Teresa Serafino on the Legal team has signed off.
  • Tag others as reviewers as necessary.
  • If you have modified any links, be sure to add redirects to assets > js > broken_redirect_list.js
⭐ Helpful Wiki Shortcuts
❗ ATTN: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Read our Previewing Documentation page to see how to check the deployment.
    • Preview all changes in the linked Vercel environment by clicking the preview link in the vercel-bot comment in your PR.
❗ ATTN: Internal Reviewing Chart
Work at Braze and not sure who to tag for review?
Before tagging @josh-mccrowell-braze or @internetisaiah for a general review, reference the following chart to see if a specific product vertical/reviewer applies to your pull request.

Reviewer Product Vertical
@josh-mccrowell-braze Monolith Deployments
Quality Infrastructure
Platform Infrastructure
Datalake
SDKs
Currents
@internetisaiah Developer Guide
Technology partners
Channels
@bre-fitzgerald Intelligence
In-App Messages
Channels
Frontend Infrastructure & Experience (FIX)
@lydia-xie Ingestion
Core Objects
Core Messaging
Messaging Experience
Message Components
Email (Composition and Infrastructure) (tag @rachel-feinberg for Liquid use cases)
@rachel-feinberg Customer Lifecycle, Identity and Permissions
SMS
User Targeting
Reporting

@internetisaiah internetisaiah self-assigned this Jun 27, 2024
@cla-bot cla-bot bot added the cla-signed label Jun 27, 2024
@internetisaiah internetisaiah requested a review from lydia-xie June 27, 2024 22:11
@internetisaiah internetisaiah marked this pull request as ready for review June 27, 2024 22:11
Copy link
Contributor

@lydia-xie lydia-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Might need to flag that a FR doc has been updated with Zeyuan, not sure 🤔

@internetisaiah
Copy link
Contributor Author

@cla-bot check

Copy link

cla-bot bot commented Jun 28, 2024

The cla-bot has been summoned, and re-checked this pull request!

@internetisaiah
Copy link
Contributor Author

@zzhaobraze , looks like the vercel issue is good on this one. we can merge this one and refresh fr whenever you're free. just let me know 👍🏽

@zzhaobraze
Copy link
Collaborator

@internetisaiah the FR should be updated once merged to main.

@internetisaiah
Copy link
Contributor Author

*Fixing merge conflicts

@internetisaiah internetisaiah merged commit 9a13faf into develop Jul 9, 2024
4 checks passed
@internetisaiah internetisaiah deleted the fix_404s_240626 branch July 9, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants