-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update notes on non-default optional data collection #7632
Conversation
8609d07
to
4ba546f
Compare
_docs/_user_guide/data_and_analytics/user_data_collection/sdk_data_collection.md
Outdated
Show resolved
Hide resolved
…data_collection.md Co-authored-by: Daniel Hok <4797040+hokstuff@users.noreply.github.com>
| ---------------- | ------------------ | ------------------------------------------------------ | --------------------------------------------------- | | ||
| Device Ad Tracking Enabled | Android, iOS | [set(adTrackingEnabled:)](https://braze-inc.github.io/braze-swift-sdk/documentation/brazekit/braze/set(adtrackingenabled:)) for iOS; on Android, this is collected via [`Braze.setGoogleAdvertisingId()`](https://braze-inc.github.io/braze-android-sdk/kdoc/braze-android-sdk/com.braze/-i-braze/set-google-advertising-id.html) | This property requires additional app-level permissions, which must be granted by the integrator. | | ||
| Device IDFA | iOS | Device identifier for advertisers | This requires the Ad Tracking Transparency framework, which will trigger additional privacy review from the App Store. For more details, see [set(identifierForAdvertiser:)](https://braze-inc.github.io/braze-swift-sdk/documentation/brazekit/braze/set(identifierforadvertiser:)) | | ||
| Google Advertising ID | Android | Identifier for advertising within Google Play apps | This requires declaring explicit permissions in the app-level manifest file. For more details, refer to [Optional Google Advertising ID]({{site.baseurl}}/developer_guide/platform_integration_guides/android/initial_sdk_setup/optional_gaid_collection) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
"This requires the app to retrieve the GAID and pass it to Braze. For more details, refer to Optional Google Advertising ID"
We don't get the ID at all because code-scanners get tripped up by this. Also, we don't reference that permission anywhere on that page either. We just refer to the Google requirements.
_docs/_user_guide/data_and_analytics/user_data_collection/sdk_data_collection.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jackson Miller <71667842+jacksonemiller@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Updates the incorrect data collection details, specifically around ad tracking properties for both iOS and Android. These pieces of data are not collected by default on either Braze SDK and requires explicit customer opt-in.