Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-5070] Add Feature Flag expanded properties for Wrapper SDKs #7697

Merged
merged 7 commits into from
Aug 14, 2024

Conversation

vanessaland
Copy link
Contributor

@vanessaland vanessaland commented Jul 17, 2024

Summary

My PR adds code examples for the Wrapper SDKs (React Native, Cordova, Unity, Flutter, Roku) for accessing the expanded Feature Flag properties. Also updated the comments to be consistent and easier to read.

Related PRs, issues, or features (optional)

Feature release date (optional)

  • Next week (Week of July 22-26)

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

@cla-bot cla-bot bot added the cla-signed label Jul 17, 2024
@vanessaland vanessaland marked this pull request as ready for review July 17, 2024 17:14
@vanessaland vanessaland requested a review from a team July 17, 2024 17:14
Copy link
Contributor

@jerielng jerielng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we should probably hold off on merging until each of the wrappers release.

Co-authored-by: Jeriel Ng <jerielng@users.noreply.github.com>
@vanessaland vanessaland added the status: do not merge Could mean research before "in progress" status, or do not merge yet. label Jul 18, 2024
@vanessaland
Copy link
Contributor Author

Hi @internetisaiah , this PR is ready for Docs Team review!

We have been rolling out each of the Wrapper Releases that include these changes. This PR is still on hold until all are released, but I'll update you when it's ready to be merged. Thanks!

@internetisaiah internetisaiah self-requested a review August 13, 2024 17:01
Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just waiting on clarification on the currently open conversation. @vanessaland , just ping me here when this one's ready to be merged and released!

@internetisaiah internetisaiah merged commit 3374d01 into develop Aug 14, 2024
3 checks passed
@internetisaiah internetisaiah deleted the SDK-5070 branch August 14, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed status: do not merge Could mean research before "in progress" status, or do not merge yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants