-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK Untracked] Update Appsflyer integration code snippet #7758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swift portion LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update the Objective-C portion as well?
BRZConfiguration *configurations = [[BRZConfiguration alloc] initWithApiKey:@"BRAZE_API_KEY" endpoint:@"BRAZE_END_POINT"];
[configurations setUseUUIDAsDeviceId:NO];
Braze *braze = [[Braze alloc] initWithConfiguration:configurations];
[braze deviceIdWithCompletion:^(NSString * _Nonnull brazeDeviceId) {
NSLog(@">>[BRZ]: %@", brazeDeviceId);
[[AppsFlyerLib shared] setAdditionalData:@{
@"brazeDeviceId": brazeDeviceId
}];
}];
I believe the deviceIdWithCompletion
method is deprecated in favor of just the deviceId
variable.
While we're at it, could we also swap the order of the Obj-C and Swift tabs so that Swift appears first as the default?
Hi @jacksonemiller : Just let us know when this one is ready for techwriter approval! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for your review @internetisaiah. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
This one's good to go @jacksonemiller . Ready to merge? |
Yep. Thanks! |
Summary
Relevant page: https://braze-docs-j2admcsrq-braze.vercel.app/docs/partners/message_orchestration/attribution/appsflyer/appsflyer/?tab=swift
Follow up to this support issue. The
deviceId
method used in these code snippets was deprecated in 5.13.0.Contributor checklist
Submitting for review
If your PR meets the above requirements, select Ready for review, then add a reviewer:
braze-inc/docs-team
as the reviewer.braze-inc/docs-team
instead.Thanks for contributing! We look forward to reading your work.