Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK Untracked] Update Appsflyer integration code snippet #7758

Merged
merged 6 commits into from
Aug 14, 2024

Conversation

jacksonemiller
Copy link
Contributor

@jacksonemiller jacksonemiller commented Jul 25, 2024

Summary

Relevant page: https://braze-docs-j2admcsrq-braze.vercel.app/docs/partners/message_orchestration/attribution/appsflyer/appsflyer/?tab=swift

Follow up to this support issue. The deviceId method used in these code snippets was deprecated in 5.13.0.

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link
Contributor

@jerielng jerielng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swift portion LGTM

Copy link
Contributor

@jerielng jerielng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the Objective-C portion as well?

BRZConfiguration *configurations = [[BRZConfiguration alloc] initWithApiKey:@"BRAZE_API_KEY" endpoint:@"BRAZE_END_POINT"];
[configurations setUseUUIDAsDeviceId:NO];
Braze *braze = [[Braze alloc] initWithConfiguration:configurations];
[braze deviceIdWithCompletion:^(NSString * _Nonnull brazeDeviceId) {
    NSLog(@">>[BRZ]: %@", brazeDeviceId);
    [[AppsFlyerLib shared] setAdditionalData:@{
        @"brazeDeviceId": brazeDeviceId
    }];
}];

I believe the deviceIdWithCompletion method is deprecated in favor of just the deviceId variable.

While we're at it, could we also swap the order of the Obj-C and Swift tabs so that Swift appears first as the default?

@josh-mccrowell-braze
Copy link
Collaborator

Hi @jacksonemiller : Just let us know when this one is ready for techwriter approval!

Copy link
Contributor

@hokstuff hokstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after swapping the order to make the Swift tab the default

This is what I see from the deployment still with ObjC as the default:
Screenshot 2024-08-06 at 4 08 47 PM

@jacksonemiller
Copy link
Contributor Author

Ready for your review @internetisaiah.

@internetisaiah internetisaiah self-requested a review August 13, 2024 21:32
Copy link
Contributor

@internetisaiah internetisaiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@internetisaiah
Copy link
Contributor

This one's good to go @jacksonemiller . Ready to merge?

@jacksonemiller
Copy link
Contributor Author

This one's good to go @jacksonemiller . Ready to merge?

Yep. Thanks!

@internetisaiah internetisaiah merged commit dc0e292 into develop Aug 14, 2024
3 checks passed
@internetisaiah internetisaiah deleted the sdk-untracked-appflyer-integration branch August 14, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants