-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BD-3340 Update catalog Liquid #7831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@@ -247,15 +247,15 @@ Do that | |||
``` | |||
{% endraw %} | |||
|
|||
Note that you must declare the catalog list before using `if` statements. In the example above, `Test-list` is the catalog list. | |||
You must declare the catalog list before using `if` statements. In the example above, `Test-list` is the catalog list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what a "catalog list" is but this is "test-list" is the name of a catalog.
@@ -266,6 +266,8 @@ Message if the venue name's size is less than 10 characters. | |||
``` | |||
{% endraw %} | |||
|
|||
Note that this scenario uses `catalog_selection_items` instead of `catalog_items`. This is because we're pulling items from a [selection]({{site.baseurl}}/user_guide/personalization_and_dynamic_content/catalogs/selections/), where `venue-list` is the catalog name and `venue_selection` is the selection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense
|
||
#### Use case: Liquid `if` snippet | ||
|
||
In this scenario, different messages will display if the custom attribute `venue_name` has more then 10 characters or less then 10 characters. If `venue_name` is `blank`, nothing will display. | ||
|
||
{% raw %} | ||
```liquid | ||
{% catalog_selection_items item-list selections %} | ||
{% catalog_selection_items venue-list venue_selection %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
Summary
Corrects Liquid and adds details to selection criteria
Related PRs, issues, or features (optional)
#BD-3340
Feature release date (optional)
Contributor checklist
Submitting for review
If your PR meets the above requirements, select Ready for review, then add a reviewer:
braze-inc/docs-team
as the reviewer.braze-inc/docs-team
instead.Thanks for contributing! We look forward to reading your work.