-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BD-3358 Apply templates to non-nested data & analytics docs #7865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lydia-xie
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! made some minor suggestions for your review!
@@ -404,7 +404,7 @@ SMS | |||
*Sends to Carrier* is deprecated, but will continue to be supported for users that already have it. | |||
{% endalert %} | |||
|
|||
This stat is the sum of Confirmed Deliveries, Rejections, and Sends where delivery or rejection was not confirmed by the carrier. There are instances where carriers do not provide delivery or rejected confirmation, as some carriers do not provide this confirmation or were unable to do so at the time of send. | |||
The sum of Confirmed Deliveries, Rejections, and Sends where delivery or rejection wasn't confirmed by the carrier. This includes instances where carriers don't provide delivery or rejected confirmation, as some carriers don't provide this confirmation or can't do so at the time of send. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
The sum of Confirmed Deliveries, Rejections, and Sends where delivery or rejection wasn't confirmed by the carrier. This includes instances where carriers don't provide delivery or rejected confirmation, as some carriers don't provide this confirmation or can't do so at the time of send. | |
The sum of *Confirmed Deliveries*, *Rejections*, and *Sends* where delivery or rejection wasn't confirmed by the carrier. This includes instances where carriers don't provide delivery or reject confirmation, as some carriers don't provide this confirmation or can't do so at the time of sending. |
Co-authored-by: Lydia Xie <87040416+lydia-xie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
My PR...
Related PRs, issues, or features (optional)
#BD-3358
Feature release date (optional)
Contributor checklist
Submitting for review
If your PR meets the above requirements, select Ready for review, then add a reviewer:
braze-inc/docs-team
as the reviewer.braze-inc/docs-team
instead.Thanks for contributing! We look forward to reading your work.