Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BD-3358 Apply templates to non-nested data & analytics docs #7865

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

rachel-feinberg
Copy link
Contributor

Summary

My PR...

Related PRs, issues, or features (optional)

#BD-3358

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link
Contributor

@lydia-xie lydia-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! made some minor suggestions for your review!

_docs/_user_guide/data_and_analytics/creating_a_formula.md Outdated Show resolved Hide resolved
_docs/_user_guide/data_and_analytics/report_metrics.md Outdated Show resolved Hide resolved
_docs/_user_guide/data_and_analytics/report_metrics.md Outdated Show resolved Hide resolved
@@ -404,7 +404,7 @@ SMS
*Sends to Carrier* is deprecated, but will continue to be supported for users that already have it.
{% endalert %}

This stat is the sum of Confirmed Deliveries, Rejections, and Sends where delivery or rejection was not confirmed by the carrier. There are instances where carriers do not provide delivery or rejected confirmation, as some carriers do not provide this confirmation or were unable to do so at the time of send.
The sum of Confirmed Deliveries, Rejections, and Sends where delivery or rejection wasn't confirmed by the carrier. This includes instances where carriers don't provide delivery or rejected confirmation, as some carriers don't provide this confirmation or can't do so at the time of send.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The sum of Confirmed Deliveries, Rejections, and Sends where delivery or rejection wasn't confirmed by the carrier. This includes instances where carriers don't provide delivery or rejected confirmation, as some carriers don't provide this confirmation or can't do so at the time of send.
The sum of *Confirmed Deliveries*, *Rejections*, and *Sends* where delivery or rejection wasn't confirmed by the carrier. This includes instances where carriers don't provide delivery or reject confirmation, as some carriers don't provide this confirmation or can't do so at the time of sending.

_docs/_user_guide/data_and_analytics/report_metrics.md Outdated Show resolved Hide resolved
Co-authored-by: Lydia Xie <87040416+lydia-xie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants