Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-3389] Revert "Update event documentation" #7921

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

internetisaiah
Copy link
Contributor

@internetisaiah internetisaiah commented Aug 20, 2024

Summary

This reverts commit 6fdac9a.

Related PRs, issues, or features (optional)

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

@cla-bot cla-bot bot added the cla-signed label Aug 20, 2024
@internetisaiah internetisaiah changed the title Revert "Update event documentation" [BD-3389] Revert "Update event documentation" Aug 20, 2024
@internetisaiah
Copy link
Contributor Author

Hey @jeffreystutz , I believe this reverts your requested changes, but do you mind double-checking and reviewing the PR?

@internetisaiah internetisaiah marked this pull request as ready for review August 20, 2024 15:57
@internetisaiah internetisaiah self-assigned this Aug 20, 2024
@jeffreystutz
Copy link
Contributor

I still see separate tabs for each destination, so I think this doesn't go back far enough unfortunately.

@internetisaiah
Copy link
Contributor Author

@jeffreystutz , do you know about how far back it should go?

@internetisaiah internetisaiah merged commit 56a4767 into develop Aug 20, 2024
3 checks passed
@internetisaiah internetisaiah deleted the reverting-commit-6fdac9a branch August 20, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants