Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INN-1790] Add ingestion as codeowners #8163

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Conversation

johnwu-braze
Copy link
Contributor

@johnwu-braze johnwu-braze commented Sep 27, 2024

Why are you making this change? (required)

Ingestion owns data transformation templates for a variety of braze endpoints. We are setting up the codeowners here to be notified when these endpoint interfaces change so we can update our templates accordingly.

Related PRs, issues, or features (optional)

  • N/A

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link

cla-bot bot commented Sep 27, 2024

We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, please fill out the information here. To re-call the cla-bot, comment @cla-bot check.

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
braze-docs-ko ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 6:42pm

@johnwu-braze
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Sep 27, 2024
Copy link

cla-bot bot commented Sep 27, 2024

The cla-bot has been summoned, and re-checked this pull request!

@josh-mccrowell-braze
Copy link
Collaborator

Update: Touched base briefly with Bart to get context. Will discuss and finalize next week!

@josh-mccrowell-braze
Copy link
Collaborator

@cla-bot check

Copy link

cla-bot bot commented Oct 1, 2024

The cla-bot has been summoned, and re-checked this pull request!

@josh-mccrowell-braze josh-mccrowell-braze merged commit c7c93c0 into develop Oct 1, 2024
5 checks passed
@josh-mccrowell-braze josh-mccrowell-braze deleted the inn-codeowners branch October 1, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants