Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CO-2975: Allow recipients to be specified via email - MERGE 10/8 #8164

Merged
merged 4 commits into from
Oct 8, 2024
Merged

CO-2975: Allow recipients to be specified via email - MERGE 10/8 #8164

merged 4 commits into from
Oct 8, 2024

Conversation

davehensley
Copy link
Contributor

@davehensley davehensley commented Sep 27, 2024 •
edited
Loading

Why are you making this change? (required)

Core Objects is adding a feature to allow requests to the /campaigns/trigger/send and /canvas/trigger/send endpoints to specify the recipient(s) by email address (instead of by external ID or user alias).

Related PRs, issues, or features (optional)

Feature release date (optional)

  • Most likely 8 October 2024

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

@cla-bot cla-bot bot added the cla-signed label Sep 27, 2024
@lydia-xie lydia-xie self-assigned this Sep 27, 2024
@lydia-xie lydia-xie changed the title CO-2975 Allow recipients to be specified via email. CO-2975 Allow recipients to be specified via email - MERGE 10/8 Sep 27, 2024
@lydia-xie lydia-xie changed the title CO-2975 Allow recipients to be specified via email - MERGE 10/8 CO-2975: Allow recipients to be specified via email - MERGE 10/8 Sep 27, 2024
@lydia-xie lydia-xie marked this pull request as ready for review October 8, 2024 14:50
@lydia-xie lydia-xie requested review from a team as code owners October 8, 2024 14:50
@josh-mccrowell-braze
Copy link
Collaborator

Hey @davehensley , this one is scheduled to go out today. Do you have reviewers that still need to sign off on this PR? Is it ready for the tech writing team to review?

@davehensley
Copy link
Contributor Author

Hey @davehensley , this one is scheduled to go out today. Do you have reviewers that still need to sign off on this PR? Is it ready for the tech writing team to review?

Hi @josh-mccrowell-braze, it's ready for your team to review, and I've asked my team to take a quick look as well before it goes out. Thank you!

@lydia-xie lydia-xie self-requested a review October 8, 2024 17:13
lydia-xie
lydia-xie approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@lydia-xie lydia-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! marking as approved and waiting for a review from the CO team

@lydia-xie lydia-xie merged commit 649d8c8 into develop Oct 8, 2024
1 check passed
@lydia-xie lydia-xie deleted the CO-2975_specify_recipients_using_email branch October 8, 2024 17:41
@josh-mccrowell-braze josh-mccrowell-braze mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shihanxiong shihanxiong shihanxiong approved these changes

@lydia-xie lydia-xie lydia-xie approved these changes

@johndinh johndinh Awaiting requested review from johndinh

@Vector919 Vector919 Awaiting requested review from Vector919

@raghavnarain3 raghavnarain3 Awaiting requested review from raghavnarain3

@brihicks5 brihicks5 Awaiting requested review from brihicks5

@mkigikm mkigikm Awaiting requested review from mkigikm

@dekel1207 dekel1207 Awaiting requested review from dekel1207

@HVisagie HVisagie Awaiting requested review from HVisagie

@LiZhangBraze LiZhangBraze Awaiting requested review from LiZhangBraze

@jayhahn jayhahn Awaiting requested review from jayhahn jayhahn is a code owner automatically assigned from braze-inc/ingestion

@parsonsj parsonsj Awaiting requested review from parsonsj parsonsj is a code owner automatically assigned from braze-inc/ingestion

@mparadiso94 mparadiso94 Awaiting requested review from mparadiso94 mparadiso94 is a code owner automatically assigned from braze-inc/ingestion

@bartlam18 bartlam18 Awaiting requested review from bartlam18 bartlam18 is a code owner automatically assigned from braze-inc/ingestion

@zwang2999 zwang2999 Awaiting requested review from zwang2999 zwang2999 is a code owner automatically assigned from braze-inc/ingestion

@johnwu-braze johnwu-braze Awaiting requested review from johnwu-braze johnwu-braze is a code owner automatically assigned from braze-inc/ingestion

Assignees

@lydia-xie lydia-xie

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davehensley @josh-mccrowell-braze @shihanxiong @lydia-xie