Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ko to dropdown #8566

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Add ko to dropdown #8566

merged 2 commits into from
Dec 6, 2024

Conversation

zzhaobraze
Copy link
Collaborator

Why are you making this change? (required)

Your reason here...

Related PRs, issues, or features (optional)

  • N/A

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

@josh-mccrowell-braze
Copy link
Collaborator

@zzhaobraze Should we make the dropdown list alphabetical (always keeping EN at the top)? So the order can be:
EN
ES
FR
JA
KO

@iaraltkorn Any thoughts?

@zzhaobraze
Copy link
Collaborator Author

@zzhaobraze Should we make the dropdown list alphabetical (always keeping EN at the top)? So the order can be: EN ES FR JA KO

@iaraltkorn Any thoughts?

reordered

@josh-mccrowell-braze josh-mccrowell-braze merged commit b66760a into develop Dec 6, 2024
5 of 7 checks passed
@josh-mccrowell-braze josh-mccrowell-braze deleted the add_ko_dropdown branch December 6, 2024 01:57
@iaraltkorn
Copy link
Collaborator

@zzhaobraze sorry i was offline - this looks good. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants