Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Cleaning up feature flags + banner cards #8604

Merged
merged 6 commits into from
Dec 10, 2024

Conversation

internetisaiah
Copy link
Contributor

@internetisaiah internetisaiah commented Dec 10, 2024

Why are you making this change? (required)

The platform_wide directory has been decommissioned, but these docs may have accidentally re-added it to the repo. I have also applied some style changes, to better match the work going on here: #8273.

Note: in a future PR, i will rename platform_integration_guides to platforms, which hopefully makes the now-missing platform_wide directory make more intuitive sense.

Related PRs, issues, or features (optional)

  • Changes have also been made to the other repo. Merge both simultaneously so the cross-references work appropriately.

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link
Collaborator

@bre-fitzgerald bre-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm with a few minor comments!

Co-authored-by: Bre Fitzgerald <82903296+bre-fitzgerald@users.noreply.github.com>
@internetisaiah internetisaiah merged commit 5f11e53 into develop Dec 10, 2024
1 of 7 checks passed
@internetisaiah internetisaiah deleted the cleaning-up-dev-docs-structure branch December 10, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants