Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BD-3715 No entry or exit events for split steps #8665

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

rachel-feinberg
Copy link
Contributor

Why are you making this change? (required)

Clarify that there are no entry or exit events for split steps.

Related PRs, issues, or features (optional)

BD-3715

Feature release date (optional)

  • N/A

Contributor checklist

  • I confirm that my PR meets the following:
    • I signed the Contribution License Agreement (CLA).
    • My style and voice follows the Braze Style Guide.
    • My content contains correct spelling and grammar.
    • All links are working correctly.
    • If I renamed or moved a file or directory, I set up URL redirects for each file.
    • If I updated or replaced an image, I did not remove the original image file from the repository. (For more information, see Updating an image).
    • If my PR is related to a paid SKU, third party, SMS, AI, or privacy, I have received written approval from Braze Legal.

Submitting for review

If your PR meets the above requirements, select Ready for review, then add a reviewer:

  • Non-Braze contributors: Add braze-inc/docs-team as the reviewer.
  • Braze employees: Have any relevant subject matter experts (like engineers or product managers) review your work first, then add the tech writer assigned to your specific vertical. If you're not sure which tech writer to add, you can add braze-inc/docs-team instead.

Thanks for contributing! We look forward to reading your work.

Copy link
Contributor

@lydia-xie lydia-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! merge when you're ready :)

@RishiHQ
Copy link

RishiHQ commented Dec 20, 2024

thanks Rachel! I would do a variation like this to make it clear (clarifying events occur when steps progress through a step), feel free to adjust the wording:

This event occurs when a user progresses through a step in a Canvas with some outcome. Note this event does not occur when steps are entered or exited. Currently, only split steps (Audience Paths, Decision Split, Action Paths, Experiment) and advance outcomes generate step progression events.

@rachel-feinberg rachel-feinberg merged commit 6cc1561 into develop Dec 20, 2024
7 checks passed
@rachel-feinberg rachel-feinberg deleted the bd-3715 branch December 20, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants