Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link button #43

Merged
merged 18 commits into from
Oct 24, 2022
Merged

Add link button #43

merged 18 commits into from
Oct 24, 2022

Conversation

zunda-arrow
Copy link
Collaborator

@zunda-arrow zunda-arrow commented Oct 23, 2022

Create link button

Used like flare.Row(button, flare.LinkButton("google.com", label="Your mom")

@hypergonial
Copy link
Member

Question: Why doesn't a Component have a custom_id or cookie? Seems like those should be inherited from there even if it may not have params. Also probably good for future-proofing since these could be used for modal components like TextInputs too.

@zunda-arrow
Copy link
Collaborator Author

There is no cookie since link button components don't have one. I don't think modal components would have one either.
I didn't give it a custom id because I think it would get messy with link buttons wanting a url and everything else wanting a custom id. I can change it so that Link button has that attribute and it's the same as url thought.

@zunda-arrow
Copy link
Collaborator Author

zunda-arrow commented Oct 23, 2022

Wondering if we need traits: Component, SupportsCallback, SupportsCookie

@hypergonial
Copy link
Member

Wondering if we need traits: Component, SupportsCallback, SupportsCookie

Yeah this might be a way. Component is the base cls, then we implement seperate traits on the ones that actually have a callback or cookie.

@zunda-arrow
Copy link
Collaborator Author

Wondering if we need traits: Component, SupportsCallback, SupportsCookie

Done

@zunda-arrow zunda-arrow merged commit 27f53a9 into main Oct 24, 2022
@zunda-arrow zunda-arrow deleted the task/link-buttons branch October 24, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants