Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: is_valid_cnpj #36

Merged
merged 3 commits into from
Mar 11, 2023
Merged

feat: is_valid_cnpj #36

merged 3 commits into from
Mar 11, 2023

Conversation

antoniamaia
Copy link
Member

Closes #35

@camilamaia camilamaia self-requested a review March 11, 2023 12:46
camilamaia
camilamaia requested changes Mar 11, 2023
View reviewed changes
Copy link
Member

@camilamaia camilamaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR! I have added two minor suggestions. And just a heads up that the check lint is failing,

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README_PT_BR.md Outdated Show resolved Hide resolved
README_PT_BR.md Show resolved Hide resolved
antoniamaia and others added 2 commits March 11, 2023 09:51
@antoniamaia @camilamaia
Apply suggestions from code review
7fa94e6 
Co-authored-by: Camila Maia <cmaiacd@gmail.com>
@antoniamaia
fix format
c8fef62
@camilamaia camilamaia merged commit 6c245c4 into brazilian-utils:main Mar 11, 2023
@camilamaia camilamaia mentioned this pull request Jul 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamaia camilamaia camilamaia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add isValidCNPJ method
2 participants
@antoniamaia @camilamaia