Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Select styles from a dropdown #9

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Sebobo
Copy link

@Sebobo Sebobo commented Sep 25, 2019

This change makes it possible to configure buttons which open
a dropdown with multiple styling selections.

With this multiple groups of styling options can be applied to a text selection.

Resolves: #2

@breadlesscode
Copy link
Owner

@Sebobo Is there a way to contribute to this draft PR, without merging it?

@Sebobo
Copy link
Author

Sebobo commented Oct 28, 2019

@breadlesscode of course. I enabled "Allow edits from maintainers". You should simply be able to push to my branch.

onClick={this.handleClick}
title={i18nRegistry.translate(tooltip)}
/>
{isOpen ? (
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you creating a group of SelectBoxes instead of a singel SelectBox? Is there a reason for that?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for each Attribute (in the example above color and size). There can be multiple attributes/styles in one styling button.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly

@Sebobo
Copy link
Author

Sebobo commented Nov 4, 2019

When I created the first version for the customer they used multiple selectboxes. For example one for the font size, one for the style and one for the color.

@pmaas
Copy link

pmaas commented Aug 2, 2020

Any plans to merge this feature? Sounds very useful :)

@breadlesscode
Copy link
Owner

Any plans to merge this feature? Sounds very useful :)

Sorry, much work here but no time. :(

But you can help If you can 👍

Neos.Ui 3.7.0 includes more CK classes which
can be used by plugins without causing CK to
throw warnings of duplicate inclusions.
@markusguenther markusguenther force-pushed the feature/dropdown-selection branch from db0f472 to 611d3e3 Compare December 15, 2020 20:39
@markusguenther
Copy link
Collaborator

Screenshot 2020-12-15 at 22 18 57

Updated the PR but still needs to find out why the change of the dropdown does not apply.

@mhsdesign
Copy link

A working alternative: https://github.com/techdivision/ckstyles ;)

I think they implemented the remove formatting better:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow choosing the style from a dropdown
6 participants