-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Select styles from a dropdown #9
base: master
Are you sure you want to change the base?
Conversation
@Sebobo Is there a way to contribute to this draft PR, without merging it? |
@breadlesscode of course. I enabled "Allow edits from maintainers". You should simply be able to push to my branch. |
onClick={this.handleClick} | ||
title={i18nRegistry.translate(tooltip)} | ||
/> | ||
{isOpen ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you creating a group of SelectBoxes instead of a singel SelectBox? Is there a reason for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for each Attribute (in the example above color
and size
). There can be multiple attributes/styles in one styling button.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly
When I created the first version for the customer they used multiple selectboxes. For example one for the font size, one for the style and one for the color. |
Any plans to merge this feature? Sounds very useful :) |
Sorry, much work here but no time. :( But you can help If you can 👍 |
Neos.Ui 3.7.0 includes more CK classes which can be used by plugins without causing CK to throw warnings of duplicate inclusions.
db0f472
to
611d3e3
Compare
A working alternative: https://github.com/techdivision/ckstyles ;) |
This change makes it possible to configure buttons which open
a dropdown with multiple styling selections.
With this multiple groups of styling options can be applied to a text selection.
Resolves: #2