Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitmodules to work with latest version of git #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update .gitmodules to work with latest version of git #120

wants to merge 1 commit into from

Conversation

adamgall
Copy link

@adamgall adamgall commented Jan 9, 2020

Sometime between git version 2.19.0 and 2.22.0 git changed the way it parses repository URLs in .gitmodules, and now swift-protobuf won't update after git submodule initing with the slash-ending URL.

Fixed by updating the url for swift-protocol to end in .git instead of / in .gitmodules

Was receiving error:

$ git submodule init
Submodule 'Modules/breadwallet-core' (https://github.com/breadwallet/breadwallet-core.git) registered for path 'Modules/breadwallet-core'
Submodule 'Modules/swift-protobuf' (https://github.com/breadwallet/swift-protobuf/) registered for path 'Modules/swift-protobuf'

$ git submodule update
Cloning into '.../breadwallet-ios/Modules/breadwallet-core'...
Cloning into '.../breadwallet-ios/Modules/swift-protobuf'...
ERROR: Repository not found.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'https://github.com/breadwallet/swift-protobuf/' into submodule path '.../breadwallet-ios/Modules/swift-protobuf' failed
Failed to clone 'Modules/swift-protobuf'. Retry scheduled
Cloning into '.../breadwallet-ios/Modules/swift-protobuf'...
ERROR: Repository not found.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'https://github.com/breadwallet/swift-protobuf/' into submodule path '.../breadwallet-ios/Modules/swift-protobuf' failed
Failed to clone 'Modules/swift-protobuf' a second time, aborting

Sometime between git version 2.19.0 and 2.22.0 git changed the way it parses repository URLs in .gitmodules, and swift-protobuf stopped updating properly after "git submodule init"ing with the slash-ending URL.
Copy link

@anasoid anasoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same problem using submodule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants