Pin version of black and reformat files to match #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to check the formatting but we don't want it to randomly fail CI if black has released a new version that makes different choices. Though it has recently be declared stable so I think there is less of a chance of that.
It seems to be mostly removing u's from string. Possibly due to Python 2.7 being long dead and it doing nothing much in Python 3 (as far as I understand.)
Hopefully we shouldn't have that issue again. If we do it will represent a meaningful failure. I'm happy to roll this back if we're concerned it'll get in the way.
|
Seems to be failing on Python 3.6 (I assume it is that 3.6) so I've made #796 to remove it from the matrix as Python 3.6 has been end-of-lifed. |
|
It wasn't Python 3.6 it was the reference to Sphinx 4.3.x but we've rebased so that is no longer an issue. |
|
@michaeljones Thanks again for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this'll resolve the issue you were seeing @vermeeren. I'm sorry for adding an unpinned version to begin with.