Issue #420 - Fix for empty table body crash #422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've put together a fix for the empty table body crash from issue #420. I've done this by mostly copying the code rinoh uses when it encounters a table with an empty header and I've applied it to tables with empty bodies.
This seems to fix the behavior so that it simply produces a table with only the header.
As for a regression test, I failed to get one made as I could not quite get a comparison pdf created in the same "minimal template" style produced by the nox run. Maybe I'm missing something obvious but what is the best way to generate the pdf files in this style for these tests?
Just so its written down somewhere, the test content looks like:
Where empty_body_table.csv is just an empty file