Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Web support #34

Open
likern opened this issue Apr 9, 2021 · 3 comments
Open

Add Web support #34

likern opened this issue Apr 9, 2021 · 3 comments
Assignees
Labels
backlog enhancement New feature or request
Milestone

Comments

@likern
Copy link
Contributor

likern commented Apr 9, 2021

Support working react-native-calendar on web by using react-native-web

@likern likern added the enhancement New feature or request label Apr 9, 2021
@likern likern added this to the vnext milestone Apr 9, 2021
@nandorojo
Copy link

A few issues I'm facing on Web:

  1. export { Calendar, CalendarProps } from './Calendar' should be changed to export type { CalendarProps } from './Calendar

Currently I'm seeing this issue:

Screen Shot 2021-04-15 at 12 25 05 PM

For some reason, the JS module is exporting CalendarProps which doesn't exist. Not sure why that's happening, I haven't seen that before.

Similarly:

Attempted import error: 'SvgCircleProps' is not exported from './Circle'.

Screen Shot 2021-04-15 at 12 27 15 PM

The module folder is exporting these TS types as JS variables.

  1. After fixing those issues, I did get it to render on web. However, it doesn't actually let me swipe and the formatting is off:

Screen Shot 2021-04-15 at 12 28 34 PM

react-native-gesture-handler works on web, so I'm not exactly sure why the gestures aren't.

Thanks for the web support goal!

@likern
Copy link
Contributor Author

likern commented Apr 15, 2021

@nandorojo Not bad, not bad 😸 Honestly, it looks even better than I was expected 🤣
Could you share your Web support, so I can run it and see the current state (with described bugs).

@nandorojo
Copy link

Yup, I installed it in my app and just ran the minimal example from the readme and gave it a black background. I would make a snack but they aren't adding reanimated 2 support until later this week.

@likern likern self-assigned this Oct 19, 2021
@likern likern added the backlog label Oct 24, 2021
likern pushed a commit that referenced this issue Nov 1, 2021
Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5.
- [Release notes](https://github.com/daaku/nodejs-tmpl/releases)
- [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5)

---
updated-dependencies:
- dependency-name: tmpl
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants