Merge Changes from EUI Main #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use euiselectable * update docs text * use message props * isVirtualized, labelProps support * refactor search filters to use euiselectable * CL * clean up * add docs for new configuration options * CL fix * review feedback * fragment * docs * convert tests to cypress * update filter count based on exclusions * add recommendation for sizing * use errorMessage * fix cypress tests * docs * update docs
* add new line icons * update snapshots * update changelog * added pr link to changelog * increase line dot size per feedback
* Normalize switch labels throughout docs * Update switch writing guidelines and move examples * Make switch guidelines dos and donts and link from writing section * Adding selection controls under forms * Adding guidelines tab * Fixing es lint warning * add link to guidelines from component example * Better guidelines structure * Better example texts * Better examples texts * Switch label past tense example * Better intro * Adding `compressed` for EuiSwitch in tables * Update src-docs/src/views/selection_controls/guidelines.js Co-authored-by: florent-leborgne <florent.leborgne@elastic.co> * Update src-docs/src/views/selection_controls/guidelines.js Co-authored-by: florent-leborgne <florent.leborgne@elastic.co> * Adding more text * Update src-docs/src/views/selection_controls/guidelines.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update src-docs/src/views/form_layouts/inline_popover.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update src-docs/src/views/selection_controls/selection_controls_example.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update src-docs/src/views/selection_controls/selection_controls_example.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update src-docs/src/views/selection_controls/selection_controls_example.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update src-docs/src/views/selection_controls/selection_controls_example.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update src-docs/src/views/selection_controls/selection_controls_example.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update src-docs/src/views/selection_controls/selection_controls_example.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update src-docs/src/views/selection_controls/selection_controls_example.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update src-docs/src/views/selection_controls/selection_controls_example.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update src-docs/src/views/selection_controls/selection_controls_example.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update src-docs/src/views/selection_controls/selection_controls_example.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update src-docs/src/views/selection_controls/selection_controls_example.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Prettier * Better table example and moving "Fieldset and legend" to new section. * Fixing guidelines console errors * Updating links to new section * More fixes * Adding `generatedId` and required `onChange` * Removing unnecessary text. * Switch playground `onChange` * Update src-docs/src/views/guidelines/writing_guidelines.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update src-docs/src/views/selection_controls/selection_controls_example.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Prettier Co-authored-by: florent-leborgne <florent.leborgne@elastic.co> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
* update colorMode return types * CL * clean up * code comment casing
…it E2E testing (#5643) * Add `data-test-subj` to expand cell button - Now that it no longer has a unique className, it isn't easy for E2E tests to hook into it * Add `data-test-selected` to EuiSelectableListItem - to make the transition/check for consuming E2E tests that check for selection state to use a data-attribute since we recently switched from aria-selected to aria-checked * Add changelog entry * [PR feedback] Changelog Co-authored-by: Greg Thompson <thompson.glowe@gmail.com> Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>
…5640) * [types] Set up interface for new `renderCellPopover` API - which replaces `popoverContents` and shares some common props with `renderCellValue` * [types] Replace component popoverContents prop with renderCellPopover + improve prop documentation for renderCellValue, renderFooterCellValue * [parents] Remove passed popoverContents for renderCellPopover - in grid parent components * [cell] Remove popoverContent for renderCellPopover * Convert DefaultColumnFormatter to DefaultCellPopover + move to data_grid_cell_popover instead of popover_utils * Pass cellActions to popover renderers as JSX * Pass schema info to both renderCellValue and renderCellPopover - the popover needs this to conditionally change formatting based on schema, and renderCellValue seems like it could use this info as well * Convert default JSON popover formatter * Delete popover_utils * Add defaultPopoverRender prop to renderCellPopover - which will allow custom renderers to pass back the default renderer if they only want custom rendering for certain popovers * [misc] fix Typescript complaints in data_grid.spec file - likely created by recent Cypress reference/ts PRs * Add Cypress E2E tests for cell popover customization/rendering * [docs] Add new cell popover documentation page and examples * [docs] Remove cell popover example/logic from schema page + remove props unrelated to schema + schema.js misc cleanup: - Remove unnecessary pagination state/props - there's only 5 items - Remove unnecessary conditional JSON - Make Star Wars vs Star Trek alternating, so sorting does more - Fix aria-label - (lint) fragment, export default * [docs] Update main datagrid documentation page - remove popoverContents, add renderCellPopover - improve documentation on rendercellValue * [docs] Misc fixes/improvements to main datagrid snippet - Fix several incorrect instances of `optional` vs `required` notation - move inMemory down to sorting/pagination instead of being at the top, since it's an optional prop - misc indentation/lint fixes * Add changelog entry * [PR feedback] Change `defaultPopoverRender` to `DefaultCellPopover` - the component usage is cleaner than a render fn * [PR feedback] Documentation copy * [PR feedback] Emphasize that leaving out the cell actions is not recommended
* Update upgrading-kibana.md * deployment update * backport * clean up
…elines (#5547) * Initial text and images for Guidelines * Allowing `all` for pageCount and adding example of table saved state * Converted EuiTablePagination to FunctionComponent * [EuiTablePagination] Extending all EuiPagination props * [Breaking] Changed `hidePerPageOptions` to the positive `showPerPageOptions` * [EuiImage] Fix max-width
* Upgrade url-parse to latest * Upgrade prismjs subdependency to latest * Force prismjs to resolve to 1.27.0 * Resolve all url-parse instances to 1.5.10
…ing all columns (#5635) * Fix console error that occurs when sorting and then hiding all columns * Add changelog entry * changelog
* Move IS_JEST_ENVIRONMENT from src/dir to src/utils * Added a README to src/test
* Added `isDisabled` prop to `EuiMarkdownEditor` * Adding in CL correct PR number * Make markdown checkboxes respect isDisabled state * Adding all plugins into the base editor example. * Removing pointer events none * Preventing components like the tooltip to work in disabled state * Adding `readOnly` state * prevent markdown changes in readonly mode * Checkboxes `-isReadOnly` styles * Reverting euiFormControlReadOnlyStyle mixin * Update src/components/markdown_editor/markdown_editor_toolbar.tsx Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Addressing PR review * Removing unnecessary type * Text * Update src-docs/src/views/markdown_editor/mardown_editor_example.js Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com> * Making `prettier`! Co-authored-by: Chandler Prall <chandler.prall@gmail.com> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
* Revising EuiCombobox to WAI-ARIA 1.2 spec. * Updated EuiCombobox to WAI-ARIA 1.2 pattern * Fixing one unit test selector. * Added aria-autocomplete, aria-label to combo box." * Removing open/close button from tab order, updating snapshots. * Adding i18n to the listbox aria-label. * Adding changelog entry for PR 5636. * Refactoring the i18n to a smaller footprint. * Adjusting comments for better clarity. * Pulling latest and moving entry to main group.
* Account for `// @ts-ignore` before imports on Typescript demos
* Add regex comment breakdown
* Setup for React import regex - comment blocks, var naming
* Add react import regex & position
* Fix newline spacing between import groups
* Fix missing `@` character causing `@emotion/react` import not to be properly grouped with other imports
* Clean up remaining import regex
- remove unnecessary escapes
- remove unnecessary catches for multiple spaces - prettier will fix those
* Fix CodeSandbox not using cleaned up demo source code
* Handle source code with no EUI imports
- it's unlikely, but otherwise the code outputs `import { } from '@elastic/eui';` which we don't want
* Fix React imports that sit below other imports lines gobbling the imports that come before
* Fix consistent newline spacing between import groups once and for all(??)
- c4329bc hadn't fixed every edge case/import permutation, so I wrote some unit tests to make sure I'd fully captured everything
* Fix Typescript CodeSandboxes not opening directly to the demo file
the rabbit hole goes deeper...
* Fix babel config to not throw errors when running jest tests on src-docs/
+ configure Jest to look at src-docs components
* remove inaccurate dedent comments
- needed to dedent both texts, not just one
* Missed a __dirName (??)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide a detailed summary of your PR. Explain how you arrived at your solution. If it includes changes to UI elements include a screenshot or gif.
Checklist