feat: add stop endpoints

app/controllers/api/v1/control.js

@@ -4,7 +4,7 @@ async function checkJobName(ctx, next) {
   const { jobName } = ctx.params;
 
   if (jobName && !ctx.bree.config.jobs.some((j) => j.name === jobName))
-    return Boom.badData('Job name does not exist');
+    return ctx.throw(Boom.badData('Job name does not exist'));
 
   return next();
 }
@@ -17,4 +17,12 @@ async function start(ctx) {
   ctx.body = {};
 }
 
-module.exports = { checkJobName, start };
+async function stop(ctx) {
+  const { jobName } = ctx.params;
+
+  await ctx.bree.stop(jobName);
+
+  ctx.body = {};
+}
+
+module.exports = { checkJobName, start, stop };

routes/api/v1/index.js

@@ -21,4 +21,7 @@ router.use(api.v1.control.checkJobName);
 router.post('/start', api.v1.control.start);
 router.post('/start/:jobName', api.v1.control.start);
 
+router.post('/stop', api.v1.control.stop);
+router.post('/stop/:jobName', api.v1.control.stop);
+
 module.exports = router;

test/api/v1/stop.js

@@ -39,6 +39,8 @@ test.before(async (t) => {
 test.serial('successfully stop named job', async (t) => {
   const { api, bree } = t.context;
 
+  t.truthy(bree.workers.active);
+
   const res = await api.post(`${rootUrl}/active`).send({});
 
   t.is(res.status, 200);
@@ -51,15 +53,15 @@ test.serial('successfully stop named job', async (t) => {
 test.serial('successfully stop all jobs', async (t) => {
   const { bree, api } = t.context;
 
-  t.not(bree.workers.length, 0);
-  t.not(bree.timeouts.length, 0);
-  t.not(bree.intervals.length, 0);
+  t.not(Object.values(bree.workers).length, 0);
+  t.not(Object.values(bree.timeouts).length, 0);
+  t.not(Object.values(bree.intervals).length, 0);
 
   const res = await api.post(rootUrl).send({});
 
   t.is(res.status, 200);
 
-  t.is(bree.workers.length, 0);
-  t.is(bree.timeouts.length, 0);
-  t.is(bree.intervals.length, 0);
+  t.is(Object.values(bree.workers).length, 0);
+  t.is(Object.values(bree.timeouts).length, 0);
+  t.is(Object.values(bree.intervals).length, 0);
 });

test/jobs/basic.js

@@ -1,3 +1,18 @@
+const { parentPort } = require('worker_threads');
+
 setTimeout(() => {
   console.log('hello');
 }, 100);
+
+if (parentPort) {
+  parentPort.on('message', (message) => {
+    if (message === 'error') throw new Error('oops');
+    if (message === 'cancel') {
+      parentPort.postMessage('cancelled');
+      return;
+    }
+
+    parentPort.postMessage(message);
+    process.exit(0);
+  });
+}

test/jobs/long.js

@@ -1,3 +1,18 @@
+const { parentPort } = require('worker_threads');
+
 setTimeout(() => {
   console.log('hello');
 }, 10000);
+
+if (parentPort) {
+  parentPort.on('message', (message) => {
+    if (message === 'error') throw new Error('oops');
+    if (message === 'cancel') {
+      parentPort.postMessage('cancelled');
+      return;
+    }
+
+    parentPort.postMessage(message);
+    process.exit(0);
+  });
+}