Flutter uniFFI #510
Open
Flutter uniFFI #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add recipe descriptions
Make sure headers are linked after uniffi is built - Remove just gen recipe Add recipe descriptions
Add recipe descriptions
Make sure headers are linked after uniffi is built - Remove just gen recipe Add recipe descriptions
Closed
erdemyerebasmaz
force-pushed
the
cleanup
branch
from
b3e69b8
to
50fd301
Compare
dangeross
reviewed
Sep 30, 2024
| - name: Move Source header files | ||
| working-directory: dist/ios/Sources/BreezSDKLiquid/ | ||
| run: | | ||
| mv breez_sdk_liquidFFI.h ../../Classes |
There was a problem hiding this comment.
I think this is covered above now, but we should still remove the modulemap
There was a problem hiding this comment.
Yes, it's covered above. I have removed header file artifacts under Sources.
cleanup header file artifacts
Comment on lines
65
to
66
| cp -r ../build/lib/bindings/langs/swift/Sources ios/ | ||
| cp -r ../build/lib/bindings/langs/swift/Sources macos/ |
There was a problem hiding this comment.
We can remove these as we are downloading the bindings-swift artifact, which also includes the generated binding.... but... we need to add a step after the download to copy the ios/Sources to macos/Sources
There was a problem hiding this comment.
Update flutter_breez_liquid.c
erdemyerebasmaz
force-pushed
the
cleanup
branch
from
c789764
to
dcd9254
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to allow Flutter and Kotlin/Swift to share the binary with flutter_rust_bridge and uniFFI interfaces