Add support for paying to BOLT12 #549
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeierez
requested changes
Nov 6, 2024
dangeross
reviewed
Nov 12, 2024
Co-authored-by: Ross Savage <551697+dangeross@users.noreply.github.com>
# Conflicts: # cli/src/commands.rs # lib/core/src/sdk.rs
Don't try to extract invoice description, because it is added later during persist.
dangeross
reviewed
Nov 13, 2024
Comment on lines
+868
to
+870
| _ => Err(PaymentError::amount_missing( | ||
| "Expected PayAmount of type Receiver when processing a Bolt12 offer", | ||
| )), |
There was a problem hiding this comment.
I think it's fine to not handle the drain case now, there are issues to inverse calculate the Boltz fee #559.
Co-authored-by: Ross Savage <551697+dangeross@users.noreply.github.com>
MRH with Bolt12 is not possible because receive is not yet supported.
Removed self-transfer check TODO, because self-transfers are not possible with Bolt12 when receive is not supported.
dangeross
reviewed
Nov 18, 2024
ok300
force-pushed
the
ok300-add-bolt12
branch
from
a3477b4
to
9920648
Compare
dangeross
reviewed
Nov 18, 2024
Comment on lines
+186
to
+243
| // Add bolt12_offer column for Send Swaps | ||
| " | ||
| ALTER TABLE send_swaps RENAME TO send_swaps_old; | ||
|
|
||
| CREATE TABLE send_swaps ( | ||
| id TEXT NOT NULL PRIMARY KEY, | ||
| invoice TEXT NOT NULL UNIQUE, | ||
| bolt12_offer TEXT, | ||
| preimage TEXT, | ||
| payer_amount_sat INTEGER NOT NULL, | ||
| receiver_amount_sat INTEGER NOT NULL, | ||
| create_response_json TEXT NOT NULL, | ||
| refund_private_key TEXT NOT NULL, | ||
| lockup_tx_id TEXT, | ||
| refund_tx_id TEXT, | ||
| created_at INTEGER NOT NULL, | ||
| state INTEGER NOT NULL, | ||
| description TEXT, | ||
| id_hash TEXT, | ||
| payment_hash TEXT | ||
| ) STRICT; | ||
|
|
||
| INSERT INTO send_swaps ( | ||
| id, | ||
| invoice, | ||
| bolt12_offer, | ||
| preimage, | ||
| payer_amount_sat, | ||
| receiver_amount_sat, | ||
| create_response_json, | ||
| refund_private_key, | ||
| lockup_tx_id, | ||
| refund_tx_id, | ||
| created_at, | ||
| state, | ||
| description, | ||
| id_hash, | ||
| payment_hash | ||
| ) SELECT | ||
| id, | ||
| invoice, | ||
| NULL, | ||
| preimage, | ||
| payer_amount_sat, | ||
| receiver_amount_sat, | ||
| create_response_json, | ||
| refund_private_key, | ||
| lockup_tx_id, | ||
| refund_tx_id, | ||
| created_at, | ||
| state, | ||
| description, | ||
| id_hash, | ||
| payment_hash | ||
| FROM send_swaps_old; | ||
|
|
||
| DROP TABLE send_swaps_old; | ||
| ", |
There was a problem hiding this comment.
If we're adding a nullable column, do we need to recreate the table?
Comment on lines
+316
to
+320
| bolt11: match maybe_send_swap_bolt12_offer.is_some() { | ||
| true => None, // We don't expose the Bolt12 invoice | ||
| false => maybe_send_swap_invoice, | ||
| }, | ||
| bolt12_offer: maybe_send_swap_bolt12_offer, |
There was a problem hiding this comment.
Why don't we expose the bolt12 invoice? The bolt11 is used as the payment destination in the send swap case, so we need to use either the offer or invoice.
| Lightning(string swap_id, string description, string? preimage, string? bolt11, string? payment_hash, string? refund_tx_id, u64? refund_tx_amount_sat); | ||
| Lightning(string swap_id, string description, string? preimage, string? bolt11, string? bolt12_offer, string? payment_hash, string? refund_tx_id, u64? refund_tx_amount_sat); |
| @@ -533,7 +533,7 @@ interface GetPaymentRequest { | |||
|
|
|||
| [Enum] | |||
| interface PaymentDetails { | |||
| Lightning(string swap_id, string description, string? preimage, string? bolt11, string? payment_hash, string? refund_tx_id, u64? refund_tx_amount_sat); | |||
| Lightning(string swap_id, string description, string? preimage, string? bolt11, string? bolt12_offer, string? payment_hash, string? refund_tx_id, u64? refund_tx_amount_sat); | |||
There was a problem hiding this comment.
This change I think requires the notification plugin to be updated
roeierez
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for paying to a BOLT12 offer.
The flow is as follows:
send_payment_via_swapwith the BOLT12 invoice as argument, instead of the usual BOLT11Open questions
PaymentDetails::Lightningwith a new field forbolt12_invoice? And / or an optionalbolt12_offer?bolt11field toinvoice, so it means either BOLT11 or BOLT12 invoice?prepare? This may take a long time for slow endpoints (Phoenix), causing the user to wait a few seconds forprepareto return.sdk_common::input_parserto parse BOLT12 offers / invoice? Or keep changes local to the Liquid SDK?Open TODOs
Detect / handle MRH in BOLT12 invoiceslist_paymentsshows payments asPendinglist_paymentsshows the bolt12 invoice underbolt11(should show offer instead)