Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Real-time Sync: Add pull and merge #556

Open
wants to merge 8 commits into
base: yse-rt-persist
Choose a base branch
from
Open

Real-time Sync: Add pull and merge #556

wants to merge 8 commits into from

Conversation

hydra-yse
Copy link
Collaborator

@hydra-yse hydra-yse commented Nov 10, 2024 •
edited
Loading

Closes #502, closes #503.
Based on #555.

TODO: Test pull with local changes

@hydra-yse hydra-yse self-assigned this Nov 10, 2024
@hydra-yse hydra-yse force-pushed the yse-rt-merge branch 3 times, most recently from fa9dd75 to 8b6a409 Compare November 10, 2024 23:30
@hydra-yse hydra-yse marked this pull request as ready for review November 10, 2024 23:40
roeierez
roeierez requested changes Nov 11, 2024
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure looks good and easy to review! There are some points we need to addres.

lib/core/src/sync/client.rs Outdated Show resolved Hide resolved
lib/core/src/sync/mod.rs Outdated Show resolved Hide resolved
lib/core/src/sync/mod.rs Show resolved Hide resolved
lib/core/src/persist/receive.rs Outdated Show resolved Hide resolved
roeierez
roeierez requested changes Nov 12, 2024
View reviewed changes
lib/core/src/sync/mod.rs Outdated Show resolved Hide resolved
lib/core/src/sync/mod.rs Outdated Show resolved Hide resolved
roeierez
roeierez requested changes Nov 12, 2024
View reviewed changes
lib/core/src/sync/mod.rs Outdated Show resolved Hide resolved
lib/core/src/sync/mod.rs Outdated Show resolved Hide resolved
@hydra-yse hydra-yse force-pushed the yse-rt-persist branch 2 times, most recently from 7c1cfbc to f422c7a Compare November 13, 2024 01:59
@hydra-yse hydra-yse force-pushed the yse-rt-persist branch 2 times, most recently from 84c7f96 to 0c56f34 Compare November 13, 2024 02:25
@hydra-yse hydra-yse force-pushed the yse-rt-merge branch 3 times, most recently from 2587800 to 9a63135 Compare November 13, 2024 03:23
roeierez
roeierez requested changes Nov 13, 2024
View reviewed changes
lib/core/src/persist/sync.rs Outdated Show resolved Hide resolved
roeierez
roeierez requested changes Nov 13, 2024
View reviewed changes
lib/core/src/persist/sync.rs Outdated Show resolved Hide resolved
@hydra-yse hydra-yse force-pushed the yse-rt-persist branch 2 times, most recently from 25e3d8e to d4d28dd Compare November 14, 2024 18:26
roeierez
roeierez reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment regarding version parsing, otherwise shaping up really good and LGTM.

lib/core/src/sync/model/mod.rs Outdated Show resolved Hide resolved
@hydra-yse hydra-yse mentioned this pull request Nov 18, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeierez roeierez roeierez requested changes

@dangeross dangeross Awaiting requested review from dangeross

@ok300 ok300 Awaiting requested review from ok300

Assignees

@hydra-yse hydra-yse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hydra-yse @roeierez