Bump boltz-client
#62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydra-yse
approved these changes
Mar 26, 2024
ok300
force-pushed
the
ok300-bump-boltz-client
branch
from
d0c03f3
to
b95dae5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR bumps the
boltz-clientto the latest commit.The change brings a more detailed list of Errors. IMO it's counterproductive for us to try to group these errors into other types (for example, should
boltz_client::error::Error::Electrum(electrum_client::Error)be mapped to aServersUnreachableerror? or toBadResponse?).Therefore this PR also maps all errors from
boltz-clientto ourBoltzGenerictype, which can be later refined if necessary.