Switch to persisting invoice rather than amount #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydra-yse
force-pushed
the
yse-persist-invoice
branch
from
9c4ca7b
to
8b77ca8
Compare
ok300
approved these changes
Apr 4, 2024
hydra-yse
force-pushed
the
yse-persist-invoice
branch
from
4b0e655
to
4ae0825
Compare
ok300
reviewed
Apr 9, 2024
ok300
reviewed
Apr 9, 2024
hydra-yse
force-pushed
the
yse-persist-invoice
branch
from
4ae0825
to
43c42e7
Compare
ok300
reviewed
Apr 10, 2024
ok300
approved these changes
Apr 12, 2024
ok300
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the idea is for the user to be able to claim from any instance, the invoice is a necessary component to do so. While we could add a separate method to re-fetch the invoice from Boltz servers with the given id, perhaps persisting the invoice directly is simpler.