-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the relay extension #448
Conversation
Did you raise with with the relay team btw? EDIT: cachewerk/relay#70 |
AL2 is built with CentOS7 right? |
I think it's roughly related, yes. |
@GrahamCampbell: Why don't we build one specifically for AL2. What's the base image I should use? |
AL2 is not a suitable base image. We are AL2 but not with AL2 openssl. |
I'd probably vote for removing this extension from bref, since it is propitiatory. |
We can easily build an artifact, I just need to know the base image to use. |
Like I said, the base image is custom, as per the link in the other discussion. |
Yeah the thing with AL2 is that it ships with outdated stuff (like OpenSSL), it's a real mess. So to compile PHP (for Bref runtimes), we compile a lot of system libs ourselves, including OpenSSL (3). Our base image for Bref is https://hub.docker.com/r/bref/build-php-80 (change |
Yeah, I can just build binaries for Bref 👍 @GrahamCampbell Does Laravel use the same builds as Bref or different ones? |
Different, but soon it will be similar enough. They are also upgrading to openssl 3.0.8, in an identical way to the way bref is building it: laravel/vapor-php-build#96. Only Laravel Vapor PHP 8.1 and 8.2 runtimes are actively maintained now, with only 8.2 with an additional ARM image. By comparison, Bref has PHP 8.0, 8.1 and 8.2, all with x86_64 and arm64, with active support (though only openssl 3.0.8 on PHP 8.1 and 8.2, due to the fact that PHP 8.0 does not support it). |
Oh yeh, and note that the information in the PR description of the linked Laravel PR is largely wrong - they are not using openssl 3.1.0 - they are using 3.0.8, and will be tracking whatever version is LTS (it looks like no other 3.x will be LTS in the near future, certainly not 3.1.x). |
And why isn't everyone switching AL2023 which already has OpenSSL 3.x and leaving AL2 alone? |
Because Lambda does not support AL2023 and AWS have not replied to my question: aws/aws-lambda-base-images#92. |
As discussed with Till, I'll merge this PR for now to fix the build and the extension. We can always move later to a custom-built |
No description provided.