Accept to generate when called without the options parameter. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 28, 2016 11:32
When options is not provided, defaults are used. This allow to call generate() and generateMultiple() without having to provide an empty options object when defaults are wanted.
Current coverage is 100% (diff: 100%)@@ master #14 diff @@
===================================
Files 1 1
Lines 43 44 +1
Methods 0 0
Messages 0 0
Branches 0 0
===================================
+ Hits 43 44 +1
Misses 0 0
Partials 0 0
|
brendanashworth
requested changes
Sep 29, 2016
| @@ -30,7 +31,9 @@ console.log(password); | |||
|
|
|||
| #### `generateMultiple(amount, options)` | |||
There was a problem hiding this comment.
Do you think you could change this to how it's done in the node docs, like this?
#### generateMultiple(amount[, options])`Then we can do away with the "If the options parameter is not provided, yadda yadda.." which I think is somewhat redundant. Please do that with the above one too please :)
brendanashworth
approved these changes
Oct 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When options is not provided, defaults are used. This allow to call
generate() and generateMultiple() without having to provide an empty
options object when defaults are wanted.
README and tests updated accordingly. package.json's version left as-is.