Compare against experiment as well #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrycho
commented
Sep 15, 2021
chriskrycho
commented
- add a comparison for local fork of @glimmer/compiler
- avoid holding onto templates so we can push on actual memory behavior using the same basic infrastructure: load them for each compiler pass, and 'forget' them by consuming them from the array of template strings while doing compilation
- add a comparison for local fork of @glimmer/compiler - avoid holding onto templates so we can push on actual memory behavior using the same basic infrastructure: load them for each compiler pass, and 'forget' them by consuming them from the array of template strings while doing compilation
rwjblue
reviewed
Sep 16, 2021
There's something not working here and it doesn't matter enough to dig into it at this point in time for this little repro repo.
brendenpalmer
approved these changes
Sep 24, 2021
There's no particular value in having it visible; it's just noise when working here -- it's really only needed for the sake of easy comparison with the experiment, in fact.
Previously, we saw issues where the results were ending up varying wildly for some cases, likely because we were ending up with a dirty heap, triggering GC, and so on. Now, run in a new process each time; this produces much more consistent results. Curiously, it also shows much higher run times, but the proportions are consistent with those from previous analyses. Combined with the changes in a previous commit to generate a table, and adding in min and max values, the results currently look like this when averaged over five separate runs for each source we care about: | variant | average | min | max | | ---------------------------- | ------- | ----- | ----- | | ember-source@3.24.5 | 14381.6 | 13538 | 14790 | | ember-source@3.25.4 | 44363.6 | 43375 | 45090 | | ember-source@3.28.1 | 45368.2 | 45224 | 45484 | | @glimmer/compiler@0.65.3 | 14493.8 | 14353 | 14600 | | @glimmer/compiler@0.80.0 | 44395 | 44018 | 44679 | | @glimmer/compiler@experiment | 20633.8 | 20523 | 20777 | | @glimmer/compiler@latest | 20751.4 | 20569 | 20864 |
chriskrycho
force-pushed
the
compare-experiment
branch
from
db5a09a
to
7d4cdb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.