Get specs running under Rails 4.1.0.beta1 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when checking results in test, so we don't get clobbered by the existing default_scope on the lookup.
swanandp
added a commit
that referenced
this pull request
Feb 22, 2014
Get specs running under Rails 4.1.0.beta1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default_scope behavior appears to have changed in Rails 4.1. Previously the addition of a 'where(active: false)' would override the existing 'where(active: true)' from the default_scope. That no longer occurs in Rails 4.1. Instead one must explicitly unscope the default_scope to get the same behavior as in earlier Rails version.
The change I made to address this issue only affects the lookup of matching records in the test, and not the code in the library itself. I believe it preserves the original intent of the specs.