Let AR::Base properly lazy-loaded if Railtie is available #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be already done in acts_as_list.rb
|
Good catch, thanks @amatsuda ! |
swanandp
added a commit
that referenced
this pull request
Mar 28, 2014
Let AR::Base properly lazy-loaded if Railtie is available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the current code calls
ActsAsList::Railtie.insertin the top-level, just requiring this gem (usually via Bundler) would immediately load AR::Base and trigger all of its initializers, which would slowdown the server startup, spec execution that does not depend on AR, etc.Also, currently
ActsAsList::Railtie.insertcall happens three times on the gem initialization, which of course is actually needed to be done only once.