Only swap changed attributes which are persistable, i.e. are DB columns. #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where acts_as_list would try to swap virtual attributes, resulting in a crashing ActiveRecord's write_attribute method.
|
@swanandp I'd still like to see this merged. |
The use of select didn't break functionality, but was confusing.
| self[k], @changed_attributes[k] } | ||
| @changed_attributes.each do |k, _| | ||
| if self.class.column_names.include? k | ||
| @changed_attributes[k], self[k] = self[k], @changed_attributes[k] |
|
Looks good to me. |
swanandp
added a commit
that referenced
this pull request
Jul 6, 2015
Only swap changed attributes which are persistable, i.e. are DB columns.
|
@swanandp thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches an issue where
acts_as_list wouldtry to swap virtual attributes, resulting in a crashing ActiveRecord write_attribute method.I observed this issue in combination with
acts_as_taggable, I have attached a partial stack trace here.My solution built on a similar fix for the
paper_trailgem, from this PR.