No update list for collection classes

[IlkhamGaysin]

I see that we can block auto-updating positions in a list only for class to whom call the method acts_as_list_no_update
But what if I need to disable for parent or child classes inside a block for example:

class TodoList < ActiveRecord::Base
  has_many :todo_items, -> { order(position: :asc) }
end

class TodoItem < ActiveRecord::Base
  belongs_to :todo_list
  has_many :todo_attachments, -> { order(position: :asc) }

  acts_as_list scope: :todo_list
end

class TodoAttachment < ActiveRecord::Base
  belongs_to :todo_list
  acts_as_list scope: :todo_item
end

TodoItem.acts_as_list_no_update([TodoAttachment]) do
  TodoItem.find(10).update(position: 2)
  TodoAttachment.find(10).update(position: 1)
  TodoAttachment.find(11).update(position: 2)
end

These changes under allow to pass additional classes as an argument and don't update positions for records of the passed classes inside of the block where there might be interactions with them.

Thanks!

[IlkhamGaysin]

Please review guys @swanandp @brendon 🍻

[brendon]

Hi @IlkhamGaysin :) Thanks for this useful enhancement. I just had a few tweaks for you to make. Let me know if you have any questions :)

[brendon]

Should read:

You can also pass an array of classes as an argument to disable database updates on just those classes. It can be any ActiveRecord class that has acts_as_list enabled.

[brendon]

Perhaps your example could show an update to TodoList also, with a comment next to it stating that callbacks will be called on that object.

[brendon]

Re-use the wording from the updated README.

[brendon]

Update the example here also as per the README.

[brendon]

Since extra_klasses isn't a reserved word I think it should be extra_classes. Would you agree @swanandp?

[brendon]

I think you need a test here that tests that callbacks are still performed on a non-specified acts_as_list class when called within the block (as per the README example update.)

[IlkhamGaysin]

@brendon I've updated the PR please review 🍺

[brendon]

Thanks @IlkhamGaysin, great work! I've merged that for you now :)

[IlkhamGaysin]

@brendon awyeah, thanks 🍻