Refactor update_all_with_touch

[ledestin]

Hi,

I've refactored update_all_with_touch. If you're curious to know the reasons for my choices, I explain everything in a blog post: https://rubyclarity.com/2017/06/acts_as_list-refactoring-part-3/

[brendon]

Hi @ledestin, I think this is ok. @swanandp, did you have any thoughts?

[swanandp]

👍

A word on commits: I am normally not a fan of squashing commits, and I like how you've made small atomic commits which make your refactoring process clear.

However, for such a small diff, having 14 commits will make it future "blaming" a little tedious. In this case, I think it would be beneficial to have them merged together.

If you agree, please squash them together and rebase against master if needed. But if you strongly feel inclined to keep the commits as they are, let me know.

[brendon]

Thanks @swanandp, we can actually do this for him with the Squash and merge button if you like?

[swanandp]

@brendon I am inclined to give him a choice. What do you think?

[brendon]

Oh yes definitely. I was just meaning he doesn't have to do the squash himself if he wants it to go that way :)

[ledestin]

@swanandp @brendon I'm ok with the way it suits you, it's your project after all. Feel free to squash.