Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online demo: axis drag moves in multiple dims, constraints seem to be ignored? #47

Closed
dimateos opened this issue Jan 7, 2025 · 7 comments · Fixed by #54
Closed

Online demo: axis drag moves in multiple dims, constraints seem to be ignored? #47

dimateos opened this issue Jan 7, 2025 · 7 comments · Fixed by #54
Assignees
Labels
prio:high High priority status:done Task completed successfully type:bug Something isn't working

Comments

@dimateos
Copy link
Contributor

dimateos commented Jan 7, 2025

Hello!

Might be limitations or bugs from the web demo, but I thought it would be worth sharing:

  • The axis constraint is ignored when more than one plot is visible:
    2025-01-07_(180231)_chrome

  • Min/max locking seem to do nothing

    • Even when a single plot is visible
    • Double click to fit stops working (as if the plot was supposed to never be able to move and there would be no need?)
      2025-01-07_(180555)_chrome
  • Auto-size in all dims giggles when the user tries to drag, would make sense to disable it?

    • Could not test if this was the case for min/max lock as it did not work for me
    • Btw you can toggle auto-fit even when the min/max is locked but then it behaves broken as in the previous gif and you cannot disable until auto-fit is disabled
      2025-01-07_(181113)_chrome
@brenocq
Copy link
Owner

brenocq commented Jan 13, 2025

Hi @dimateos! Sorry for the slow reply, I was quite busy at work last week 😬

The axis constraint is ignored when more than one plot is visible

Thanks for sharing! I wasn't aware of this issue haha

Min/max locking seem to do nothing

Ohh my bad!!

Auto-size in all dims giggles when the user tries to drag, would make sense to disable it?

Ooops, I'll fix the giggle, that's very ugly

Btw you can toggle auto-fit even when the min/max is locked but then it behaves broken as in the previous gif and you cannot disable until auto-fit is disabled

I just checked the ImPlot and it looks like the auto-fit is supposed to "overwrite" the min/max lock, so I believe disabling the min/max checkbox is the expected behavior

Thanks for the feedback! I wasn't aware of any of these bugs kkkkk I'll fix them this week :)

@brenocq brenocq self-assigned this Jan 13, 2025
@brenocq brenocq added type:bug Something isn't working prio:high High priority status:todo Task identified but not started status:doing Work is currently in progress and removed status:todo Task identified but not started labels Jan 13, 2025
@brenocq brenocq linked a pull request Jan 14, 2025 that will close this issue
@brenocq
Copy link
Owner

brenocq commented Jan 14, 2025

Heey @dimateos I fixed the issues you listed in PR #54. You can build the example from dev to double-check if they are indeed fixed. The online demo may take a little to be updated since it is maintained by @pthom in implot_demo.

Let me know if you find any other issues/weird behaviors!

@brenocq brenocq closed this as completed Jan 14, 2025
@brenocq brenocq added status:done Task completed successfully and removed status:doing Work is currently in progress labels Jan 14, 2025
@dimateos
Copy link
Contributor Author

Hey Breno!

Just tried it and issues 1. and 2. are fixed and it works perfectly now.

As for issue 3. it still giggles a bit with all axis auto fit, but it seems to be much reduced!
2025-01-14_(114213)_example

I just checked the ImPlot and it looks like the auto-fit is supposed to "overwrite" the min/max lock, so I believe disabling the min/max checkbox is the expected behavior

Yeah that seems reasonable to me, I mainly pointed it out in relation to issue 2. :)

@brenocq
Copy link
Owner

brenocq commented Jan 14, 2025

As for issue 3. it still giggles a bit with all axis auto fit, but it seems to be much reduced!

Great that you noticed that there was still some giggle for the auto fit, I merged a fix for it in #60! Hopefully, all giggles were fixed!

@pthom
Copy link
Contributor

pthom commented Jan 16, 2025

@dimateos , @brenocq , I just updated the online demo. Hopefully, things are solved there too.

@dimateos
Copy link
Contributor Author

Hello Pascal,

I just checked it out and the online demo includes all the fixes! Even the last one (#60), so no giggling when all axis are locked :)

@brenocq
Copy link
Owner

brenocq commented Jan 16, 2025

Thank you so much @pthom!! Speeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio:high High priority status:done Task completed successfully type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants