Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix min/max lock & axis transformation #54

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Fix min/max lock & axis transformation #54

merged 2 commits into from
Jan 14, 2025

Conversation

brenocq
Copy link
Owner

@brenocq brenocq commented Jan 14, 2025

This PR fixes the issues found by @dimateos in #47

The fixes are:

  • Axis transformation constraint would be ignored when more than one plot was visible
  • Min/max axis lock was not working (the user could always move the axis range around as if it was not locked)
  • The plot would giggle when the user tries to move locked axes

@brenocq brenocq added type:bug Something isn't working prio:high High priority status:done Task completed successfully labels Jan 14, 2025
@brenocq brenocq self-assigned this Jan 14, 2025
@brenocq brenocq linked an issue Jan 14, 2025 that may be closed by this pull request
Online demo: axis drag moves in multiple dims, constraints seem to be ignored? #47
Closed
@brenocq brenocq merged commit 7d360e9 into dev Jan 14, 2025
8 checks passed
@brenocq brenocq deleted the fix-lock-giggle branch January 14, 2025 02:34
@brenocq brenocq mentioned this pull request Jan 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brenocq brenocq

Labels
prio:high High priority status:done Task completed successfully type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Online demo: axis drag moves in multiple dims, constraints seem to be ignored?
1 participant
@brenocq