Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Arabic Language #319

Closed
wants to merge 6 commits into from
Closed

add Arabic Language #319

wants to merge 6 commits into from

Conversation

Tayeb-Ali
Copy link
Contributor

Describe your change

Added Arabic language.

New feature checklist

  • Have you run the application to make sure your code runs
  • Is this not just a simple formatting change

Translation checklist

  • Have you run the application to make sure your code runs
  • Have you used the correct keys for your translations added (e.g. en)
  • Have you made sure to leave a , at the end of each translation added
  • Have you added the language to supportedLanguages in alphabetical order
  • Have you added the language to the table in README.md in alphabetical order
  • If you have translated the README, have you linked it in README.md

brentvollebregt
brentvollebregt requested changes Oct 19, 2022
View reviewed changes
Copy link
Owner

@brentvollebregt brentvollebregt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - just a few asks. Thank you!

README.md Outdated Show resolved Hide resolved
auto_py_to_exe/web/js/i18n.js Outdated Show resolved Hide resolved
auto_py_to_exe/web/js/i18n.js Outdated Show resolved Hide resolved
auto_py_to_exe/web/js/i18n.js Outdated Show resolved Hide resolved
auto_py_to_exe/web/js/i18n.js Outdated Show resolved Hide resolved
Tayeb-Ali and others added 3 commits October 23, 2022 10:40
@Tayeb-Ali @brentvollebregt
Update auto_py_to_exe/web/js/i18n.js
b6c5310 
Co-authored-by: Brent Vollebregt <brent.vollebregt@gmail.com>
@Tayeb-Ali @brentvollebregt
Update auto_py_to_exe/web/js/i18n.js
5df70e2 
Co-authored-by: Brent Vollebregt <brent.vollebregt@gmail.com>
@Tayeb-Ali
update
992f9aa
brentvollebregt
brentvollebregt reviewed Oct 24, 2022
View reviewed changes
Copy link
Owner

@brentvollebregt brentvollebregt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - just a couple more things regarding consistency

README.md Outdated Show resolved Hide resolved
auto_py_to_exe/web/js/i18n.js Outdated Show resolved Hide resolved
brentvollebregt added a commit that referenced this pull request Nov 13, 2022
@brentvollebregt @Tayeb-Ali
#319 Add Czech translations
486a556 
Fixed issues I raised myself in #319 since the OP was not replying anymore

Co-authored-by: ELTAYEB ALI <Tayeb-Ali@users.noreply.github.com>
brentvollebregt added a commit that referenced this pull request Nov 13, 2022
@brentvollebregt @Tayeb-Ali
#319 Add Arabic translations
7822967 
Fixed issues I raised myself in #319 since the OP was not replying anymore

Co-authored-by: ELTAYEB ALI <Tayeb-Ali@users.noreply.github.com>
@brentvollebregt
Copy link
Owner

brentvollebregt commented Nov 13, 2022 •
edited
Loading

This has been manually fixed up and added in 7822967 - it will be released soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentvollebregt brentvollebregt Awaiting requested review from brentvollebregt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tayeb-Ali @brentvollebregt