Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finnish language #373

Merged
merged 4 commits into from
Mar 4, 2023
Merged

Finnish language #373

merged 4 commits into from
Mar 4, 2023

Conversation

ZapX5
Copy link
Contributor

@ZapX5 ZapX5 commented Mar 3, 2023 •
edited
Loading

Describe your change

Added Finnish language for both the UI and README.

If this is related to an issue, please link the issue here

New feature checklist

  • Have you run the application to make sure your code runs
  • Is this not just a simple formatting change

Translation checklist

  • Have you run the application to make sure your code runs
  • Have you used the correct keys for your translations added (e.g. en)
  • Have you made sure to leave a , at the end of each translation added
  • Have you added the language to supportedLanguages in alphabetical order
  • Have you added the language to the table in README.md in alphabetical order
  • If you have translated the README, have you linked it in README.md

brentvollebregt
brentvollebregt reviewed Mar 3, 2023
View reviewed changes
Copy link
Owner

@brentvollebregt brentvollebregt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent! Thank you for the tidy work 👍

Just a couple of small requests for me and it will be ready to go in 🏄

README-Finnish.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@ZapX5
Copy link
Contributor Author

ZapX5 commented Mar 4, 2023

I did the changes now. Removed the translations section in README-Finnish.md and added "You can find the Finnish manuals here" text to line 19

@brentvollebregt brentvollebregt merged commit f4ddfbb into brentvollebregt:master Mar 4, 2023
@brentvollebregt
Copy link
Owner

Thank you for these - the changes have just been released in auto-py-to-exe v2.32.0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentvollebregt brentvollebregt brentvollebregt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZapX5 @brentvollebregt