Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify users of new PyInstaller version #469

Merged
merged 9 commits into from
Mar 22, 2024
Merged

Notify users of new PyInstaller version #469

merged 9 commits into from
Mar 22, 2024

Conversation

mcagriaksoy
Copy link
Contributor

This PR is created for the Issue #467

I have added version check on utils.py and display warning on the UI!
Also, I updated to requirements.txt

SS:
image

Tested on: Ubuntu 22.04.3 LTS, Windows 11

brentvollebregt
brentvollebregt requested changes Mar 18, 2024
View reviewed changes
Copy link
Owner

@brentvollebregt brentvollebregt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was originally aiming to do this on the client side but this looks good - my only concern is holding up the application's first load if that call is too slow but it should be ok.

Just a few small things in comments 👍

auto_py_to_exe/utils.py Show resolved Hide resolved
auto_py_to_exe/utils.py Outdated Show resolved Hide resolved
auto_py_to_exe/utils.py Outdated Show resolved Hide resolved
auto_py_to_exe/utils.py Outdated Show resolved Hide resolved
auto_py_to_exe/utils.py Outdated Show resolved Hide resolved
auto_py_to_exe/utils.py Outdated Show resolved Hide resolved
mcagriaksoy and others added 5 commits March 18, 2024 21:36
@mcagriaksoy @brentvollebregt
Update auto_py_to_exe/utils.py
5691649 
Co-authored-by: Brent Vollebregt <brent.vollebregt@gmail.com>
@mcagriaksoy @brentvollebregt
Update auto_py_to_exe/utils.py
78411f2 
Co-authored-by: Brent Vollebregt <brent.vollebregt@gmail.com>
@mcagriaksoy @brentvollebregt
Update auto_py_to_exe/utils.py
70e9b62 
Co-authored-by: Brent Vollebregt <brent.vollebregt@gmail.com>
@mcagriaksoy @brentvollebregt
Update auto_py_to_exe/utils.py
386edff 
Co-authored-by: Brent Vollebregt <brent.vollebregt@gmail.com>
@mcagriaksoy @brentvollebregt
Update auto_py_to_exe/utils.py
7dc2abb 
Co-authored-by: Brent Vollebregt <brent.vollebregt@gmail.com>
brentvollebregt
brentvollebregt requested changes Mar 19, 2024
View reviewed changes
auto_py_to_exe/utils.py Show resolved Hide resolved
auto_py_to_exe/utils.py Show resolved Hide resolved
@brentvollebregt brentvollebregt changed the title Pyinstaller version check br Notify users of new Pyinstaller version Mar 19, 2024
@brentvollebregt brentvollebregt changed the title Notify users of new Pyinstaller version Notify users of new PyInstaller version Mar 19, 2024
Mehmet Cagri Aksoy added 2 commits March 21, 2024 20:54
brentvollebregt
brentvollebregt approved these changes Mar 22, 2024
View reviewed changes
Copy link
Owner

@brentvollebregt brentvollebregt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will aim to put it in soon

@brentvollebregt brentvollebregt merged commit 8ceb81e into brentvollebregt:master Mar 22, 2024
1 check passed
@mcagriaksoy mcagriaksoy deleted the pyinstaller_version_check_br branch March 22, 2024 11:13
@brentvollebregt
Copy link
Owner

Thanks for the contribution! This has been released in v2.43.0 🚀

@brentvollebregt brentvollebregt mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentvollebregt brentvollebregt brentvollebregt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcagriaksoy @brentvollebregt