Add Hebrew translations #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvollebregt
requested changes
May 25, 2024
- adjust format. - fix translationMap key.
|
please update me regarding issue 1 and 4 (you mentioned and I responded). |
- add Hebrew ref to Trans table in main md. - format i18n. - rearrange He before Hi translations.
|
pushed new commit to resolve latest mentioned issues |
brentvollebregt
requested changes
May 27, 2024
There was a problem hiding this comment.
The formatting check failed again, here is the output from the action run:
Checking formatting...
[warn] auto_py_to_exe/web/js/i18n.js
[warn] README-Hebrew.md
[warn] README.md
[warn] Code style issues found in 3 files. Forgot to run Prettier?
Problem running prettier with --check .
|
Hey @ronbentata, not sure if you saw my couple of comments about formatting - this still needs to be sorted before merge. |
|
run prettier again to fix format on specific files |
brentvollebregt
approved these changes
May 31, 2024
brentvollebregt
approved these changes
Jun 1, 2024
|
Thanks for the contribution! This has been released in v2.44.0 🚀 |
|
Thank you!
great to contribute
*Ron Bentata*
LinkedIn: https://www.linkedin.com/in/ronbentata
Website: http://www.ronbentata.com/
please consider the environment and don't print this email
…On Wed, Jun 5, 2024 at 12:24 PM Brent Vollebregt ***@***.***> wrote:
Thanks for the contribution! This has been released in v2.44.0
<https://github.com/brentvollebregt/auto-py-to-exe/releases/tag/v2.44.0>
🚀
—
Reply to this email directly, view it on GitHub
<#488 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAX7FMZCCNBGGXNKMTF2DZLZF3KNHAVCNFSM6AAAAABIFAFXFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBZGMYTIMZQGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added an Hebrew translation + ReadMe
Translation checklist
en),at the end of each translation addedsupportedLanguagesin alphabetical order