Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Belarusian translations #491

Merged
merged 10 commits into from
Jun 5, 2024

Conversation

Zmicier21
Copy link
Contributor

@Zmicier21 Zmicier21 commented May 30, 2024

Summary

Added Belarusian language

Translation checklist

  • I have ran the application to make sure my code runs
  • I have used the correct ISO 639-1 code for my translations (e.g. en)
  • I have formatted all changes as described in the contribution style guide
  • I have added the language to supportedLanguages in alphabetical order
  • I have added the language to the table in README.md in alphabetical order
  • (If you translated the README) I have translated the README and linked it in the main README.md
  • (If you translated the README) I have left the "Translations" section out of the translated README

Add Belarusian language
Add Belarusian language (fixed)
@brentvollebregt brentvollebregt changed the title Update i18n.js Add Belarusian translations May 31, 2024
Copy link
Owner

@brentvollebregt brentvollebregt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a checklist for translations in this template - I'll update the PR to have this checklist and you can go through it 👍

Take a look at #355 if you need an example.

auto_py_to_exe/web/js/i18n.js Show resolved Hide resolved
auto_py_to_exe/web/js/i18n.js Show resolved Hide resolved
Fixed the order of languages
@brentvollebregt
Copy link
Owner

Could you add an entry to the translations table in the README.md file? Other than that, this looks good.

Add Belarusian in translations
@brentvollebregt
Copy link
Owner

Hey, I see you have 5 branches in your repo with changes that appear they should be in Zmicier21:patch-1 - do you need some help getting all these changes into this PR? Happy to move the commits around for you if you need.

Created file README.md in Belarusian
Add Belarusian in Translations
Created README in Belarusian language
@Zmicier21
Copy link
Contributor Author

I don't understand, how use git correctly

Copy link
Owner

@brentvollebregt brentvollebregt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, just two more small things thanks.

I don't understand, how use git correctly

No worries! I'm happy to help move commits around if you need.

README.md Outdated
@@ -132,6 +132,7 @@ If you believe you've found an issue with this tool, please follow the ["Reporti
| Language | Translator | Translated |
| ------------------------------------------- | -------------------------------------------------------------------------------------------- | ------------------------------------ |
| Arabic (العربية) | [Tayeb-Ali](https://github.com/tayeb-ali) | UI |
| Belarusian (Беларуская) | [Zmicier21](https://github.com/Zmicier21) | UI
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Belarusian (Беларуская) | [Zmicier21](https://github.com/Zmicier21) | UI
| Belarusian (Беларуская) | [Zmicier21](https://github.com/Zmicier21) | UI |

README.md Show resolved Hide resolved
# Conflicts:
#	README.md
Copy link
Owner

@brentvollebregt brentvollebregt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tidied the last couple of things up for you - looks good to go. Thank you for your contribution!

@brentvollebregt brentvollebregt merged commit d0c8130 into brentvollebregt:master Jun 5, 2024
1 check passed
@brentvollebregt
Copy link
Owner

Thanks for the contribution! This has been released in v2.44.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants