Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slovak translations #514

Merged
merged 13 commits into from
Dec 26, 2024
Merged

Conversation

mostypc123
Copy link
Contributor

@mostypc123 mostypc123 commented Dec 21, 2024

Summary

I added a translation to slovak.

Translation checklist

  • I have ran the application to make sure my code runs
  • I have used the correct ISO 639-1 code for my translations (e.g. en)
  • I have formatted all changes as described in the contribution style guide
  • I have added the language to supportedLanguages in alphabetical order
  • I have added the language to the table in README.md in alphabetical order

@mostypc123
Copy link
Contributor Author

@brentvollebregt please review the pr

@brentvollebregt
Copy link
Owner

Apologies for the delay - I don't have something I can review this properly right now but it looks like the prettier formatting check failed.

Other than that, this is looking ok from what I can see currently👍

@mostypc123
Copy link
Contributor Author

idk why but i formatted it two times with prettier, or do i need more config after ibstalling the vs code extension

@brentvollebregt
Copy link
Owner

What are you using to format? I used npx prettier@2.8.8 --write . on your branch as described in the contribution guidelines and it fixed the formatting issues.

@mostypc123
Copy link
Contributor Author

i used the vscode extension

@brentvollebregt
Copy link
Owner

Please use npx prettier@2.8.8 --write . as described in the contribution style guide (on the PR checklist)

@brentvollebregt
Copy link
Owner

I have the changes locally now - I'll push them for you

@mostypc123
Copy link
Contributor Author

thanks

auto_py_to_exe/web/js/i18n.js Outdated Show resolved Hide resolved
auto_py_to_exe/web/js/i18n.js Outdated Show resolved Hide resolved
auto_py_to_exe/web/js/i18n.js Outdated Show resolved Hide resolved
mostypc123 and others added 2 commits December 26, 2024 10:06
Co-authored-by: Brent Vollebregt <brent.vollebregt@gmail.com>
Co-authored-by: Brent Vollebregt <brent.vollebregt@gmail.com>
@brentvollebregt brentvollebregt changed the title slovak translation Add Slovak translations Dec 26, 2024
@mostypc123
Copy link
Contributor Author

will do the things later im on github mobile right now idk how to even use it😂

@mostypc123
Copy link
Contributor Author

looks like i figured it out, it's fixed

auto_py_to_exe/web/js/i18n.js Outdated Show resolved Hide resolved
@brentvollebregt brentvollebregt merged commit 80039cb into brentvollebregt:master Dec 26, 2024
1 check passed
@brentvollebregt
Copy link
Owner

Thanks for the contribution! This has been released in v2.45.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants