Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have a public API #18

Closed
brettcannon opened this issue Mar 7, 2023 · 3 comments · Fixed by #26
Closed

Have a public API #18

brettcannon opened this issue Mar 7, 2023 · 3 comments · Fixed by #26
Labels
impact-feature New feature

Comments

@brettcannon
Copy link
Owner

I could document microvenv.create() as a public API, but until people ask for it I don't think it's worth it since my own needs are satisfied by the CLI API.
@brettcannon
Copy link
Owner Author

brettcannon commented Mar 9, 2023 •
edited
Loading

Should be similar to venv.create() which (microvenv.create() already is). Not sure if it's worth accepting the same arguments and erroring out when a parameter is specified that isn't compatible with microvenv.

@brettcannon
Copy link
Owner Author

This would require making microvenv.create() to take any path-like object, not just pathlib.Path.

@brettcannon
Copy link
Owner Author

Would also need to rename the parameter for create().

brettcannon added a commit that referenced this issue Mar 10, 2023
@brettcannon
Add a public API via the create() function
19fa5a8 
Closes #18
@brettcannon brettcannon mentioned this issue Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact-feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a public API via the create() function brettcannon/microvenv
1 participant
@brettcannon