-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest sass with sass-embedded gem #148
Conversation
@ntkme thank you very much for this contribution! I will test it out and review it in the coming days. 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This branch is working really well for me, thank you for this improvement! 🙌 I think the call to Sass.compile
will be much more resilient than the previous implementation.
I noticed three tests are failing on main
now, let me fix those. They are seemingly unrelated to these changes.
Any updates on this and if we can get this merged? I think Thanks for the contribution! |
@mritunjaysharma394 You have a few misunderstandings here:
|
Thanks so much @ntkme for the detailed response and explaination, that really happens to clear my confusion and I am sorry for all the confusion it caused it. I just found out that it indeed uses thirdparty https://github.com/ayushn21/dartsass-ruby and possibly the name similarity caused the confusion. Thanks for all the help and really hope this PR still gets merged soon to use the maintained one. Thank you! |
An upstream change in the graphql gem broke the tests, see #149 I'd like to get that fixed so the test suite is passing before merging this. I'll work on it in the coming days and try to get this merged before the end of the weekend. Sorry for the slowness here. If anyone is interested/willing to help get the suite green, that'd be amazing and much appreciated! |
@ntkme thanks again for this contribution! |
I'm going to work on getting a new version of the gem released, likely v5.0.0 since there are breaking changes. |
The dartsass gem has never been updated since its very first release. This PR updates to latest version of dart sass using sass-embedded gem, which has version and feature matching release with dart-sass.