Skip to content

Commit

Permalink
INCOMPLETE: Need to check logic for checking/incrementing/returning key
Browse files Browse the repository at this point in the history
   as well as properly handle numbers just beyond the max allowed by ES
   since confuable if only incrementing by one
- Fix: As per new requirements, ensure numbers higher than the max
    (including non-finite) have the effect of setting the current number
    to the max
- Fix: Default to `global` where no `window` or `self` is defined
- Refactoring (SQL): (avoid unused column name in SELECT)
- Refactoring (spec): Make current number retrieval routines more closely
   parallel spec
- npm: Update ESLint and compat plugin; add shrinkwrap to better ensure
   consistency across installs (and for testing consistency)
- Grunt: Try stabilizing builds for issue indexeddbshim#291
  • Loading branch information
brettz9 committed Feb 28, 2017
1 parent ce581cc commit cc998eb
Show file tree
Hide file tree
Showing 11 changed files with 5,670 additions and 164 deletions.
2 changes: 2 additions & 0 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ module.exports = function (grunt) {
// Avoid `window` checking
browserifyOptions: {
standalone: 'dummyPlaceholder',
basedir: __dirname, // For consistency with any relative paths: http://stackoverflow.com/a/33124979/271577
builtins: false, // No need to define in Node (if there are any)
commondir: false, // No need in Node to look up to nearest common directory (if there are any)
browserField: false, // Avoid using `browser` entry in package.json
Expand Down Expand Up @@ -64,6 +65,7 @@ module.exports = function (grunt) {
// Avoid `window` checking
browserifyOptions: {
standalone: 'dummyPlaceholder',
basedir: __dirname, // For consistency with any relative paths: http://stackoverflow.com/a/33124979/271577
builtins: false, // No need to define in Node (if there are any)
commondir: false, // No need in Node to look up to nearest common directory (if there are any)
browserField: false, // Avoid using `browser` entry in package.json
Expand Down
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,8 @@ one of the following objects in order of precedence:
1. The passed in `winObj` object if defined
2. `window` (for Node, define `global.window = global;`)
3. `self` (for web workers)
4. A new object
4. `global` (for Node)
5. A new empty object

The `initialConfig` argument, if present, should be an object whose keys
are the config properties to set and its values are the config values (see
Expand Down Expand Up @@ -486,6 +487,9 @@ To run the Node tests, run the following:
the new ones are configured properly and working in the browser
as do the old tests.

If you need to rebuild SQLite, you can run `npm install` inside of the
`node_modules/sqlite3` directory.

To run a specific Mocha test (which includes the `tests-polyfill`
tests), run `npm --test=... run mocha`.

Expand Down
186 changes: 107 additions & 79 deletions dist/indexeddbshim-UnicodeIdentifiers-node.js

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions dist/indexeddbshim-UnicodeIdentifiers-node.min.js

Large diffs are not rendered by default.

Loading

0 comments on commit cc998eb

Please sign in to comment.